added missing items to feature #152
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stempler
reviewed
Nov 21, 2024
| @@ -203,6 +216,18 @@ class ArtifactFeature implements Feature { | |||
| def invokeMethod(String name, def args) { | |||
| //TODO support manually adding a feature reference | |||
There was a problem hiding this comment.
I guess the TODO can be removed then?
build.gradle
Outdated
Comment on lines
143
to
149
| doFirst { | ||
| println "isRelease: $isRelease" | ||
| println "isCI: $isCI" | ||
| } | ||
| onlyIf { | ||
| isRelease || isCI | ||
| // isRelease || isCI | ||
| false |
There was a problem hiding this comment.
ahhh, I am so sorry this change was not supposed to be a part of this pull request, now the original code is restored
|
I have also added a small explanation to README.md. I hope the content fits the rest of the document. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added missing items like copyright and description to the feature.
Another missing item are required features. So now the user may define one or more requirements for a feature, see example below:
platform {
feature(id: 'some_feature',
name: '%feature.label',
label: '%feature.label',
provider: '%feature.providerName',
license: '%license.url',
copyright: "%feature.copyright",
description: "%feature.description"
)
{
requires (
featureName: "required_feature",
version: "10.2.0",
match: "greaterOrEqual"
)
}
//here are the dependencies...
}